[ovs-dev] [next3 4/4] Implement basic multiple table support.

[Ethan Jackson]

Looks Good, minor comments.



> @@ -879,16 +887,15 @@ ofproto_delete_flow(struct ofproto *ofproto, const struct cls_rule *target)
>  {
>     struct rule *rule;
>
> -    rule = rule_from_cls_rule(classifier_find_rule_exactly(&ofproto->cls,
> -                                                           target));
> +    rule = rule_from_cls_rule(classifier_find_rule_exactly(
> +                                  &ofproto->tables[0], target));
>     ofproto_rule_destroy(rule);
>  }

I don't fully understand this function.  Why does it assume that
'target' is in table 0?


> +     * ->construct() should initialize the base 'n_tables' member to the number
> +     * of flow tables supported by the datapath (between 1 and 254, inclusive),
> +     * initialize the base 'tables' membeer with space for one classifier per

member


> +.IP \fBtable=\fInumber\fR
> +If specified, limits the flow manipulation and flow dump commands to
> +only apply to the table with the given \fInumber\fR.
> +\fInumber\fR is a number between 0 and 254, inclusive.

Should this be between 1 and 254?

Ethan