[ovs-dev] [sparse 11/18] compiler: Suppress sparse complaints about function attributes.

Ethan Jackson ethan at nicira.com
Fri May 13 00:56:41 UTC 2011


Looks Good.

Ethan

On Fri, May 6, 2011 at 13:16, Ben Pfaff <blp at nicira.com> wrote:
> GCC allows __attribute__s to be included in function prototypes and
> then omitted later on the function definition, but sparse complains about
> this.  Furthermore, sparse doesn't like the placement of the __attribute__s
> that we tend to use in OVS.
>
> I don't see any value in "fixing" these to suit sparse so it seems better
> to just omit them.
> ---
>  lib/compiler.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/compiler.h b/lib/compiler.h
> index 6bf5144..9e9eb82 100644
> --- a/lib/compiler.h
> +++ b/lib/compiler.h
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (c) 2008, 2009, 2010 Nicira Networks.
> + * Copyright (c) 2008, 2009, 2010, 2011 Nicira Networks.
>  *
>  * Licensed under the Apache License, Version 2.0 (the "License");
>  * you may not use this file except in compliance with the License.
> @@ -17,7 +17,7 @@
>  #ifndef COMPILER_H
>  #define COMPILER_H 1
>
> -#ifdef __GNUC__
> +#if __GNUC__ && !__CHECKER__
>  #define NO_RETURN __attribute__((__noreturn__))
>  #define OVS_UNUSED __attribute__((__unused__))
>  #define PRINTF_FORMAT(FMT, ARG1) __attribute__((__format__(printf, FMT, ARG1)))
> --
> 1.7.4.4
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>



More information about the dev mailing list