[ovs-dev] [sparse 16/18] test-sha1: Suppress sparse warning.

Ethan Jackson ethan at nicira.com
Fri May 13 01:07:23 UTC 2011


Looks Good.

I'm curious why this triggers a warning.  Does it expect you to use
sizeof instead?

Ethan

On Fri, May 6, 2011 at 13:16, Ben Pfaff <blp at nicira.com> wrote:
> Otherwise sparse warns: warning: memset with byte count of 1000000
> ---
>  tests/test-sha1.c |    7 +++++--
>  1 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/tests/test-sha1.c b/tests/test-sha1.c
> index 65751c8..c7aec4b 100644
> --- a/tests/test-sha1.c
> +++ b/tests/test-sha1.c
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (c) 2009 Nicira Networks.
> + * Copyright (c) 2009, 2011 Nicira Networks.
>  *
>  * Licensed under the Apache License, Version 2.0 (the "License");
>  * you may not use this file except in compliance with the License.
> @@ -127,9 +127,12 @@ test_big_vector(void)
>         { 0x34, 0xAA, 0x97, 0x3C, 0xD4, 0xC4, 0xDA, 0xA4, 0xF6, 0x1E,
>           0xEB, 0x2B, 0xDB, 0xAD, 0x27, 0x31, 0x65, 0x34, 0x01, 0x6F }
>     };
> +    size_t i;
>
>     vec.data = xmalloc(SIZE);
> -    memset(vec.data, 'a', SIZE);
> +    for (i = 0; i < SIZE; i++) {
> +        vec.data[i] = 'a';
> +    }
>     test_one(&vec);
>     free(vec.data);
>  }
> --
> 1.7.4.4
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>



More information about the dev mailing list