[ovs-dev] [warnings 8/8] tests: Check ovs-openflowd log output instead of ignoring it.

Ethan Jackson ethan at nicira.com
Fri May 13 02:41:25 UTC 2011


Looks Good.

Ethan

On Mon, May 2, 2011 at 12:58, Ben Pfaff <blp at nicira.com> wrote:
> ovs-openflowd outputs a number of log messages that we don't want to
> suppress.  We do want to know if it logs anything that we don't expect.
> So this commit starts checking the log output, discarding any normal,
> expected messages.
> ---
>  tests/ofproto-macros.at |    8 +++++++-
>  1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/tests/ofproto-macros.at b/tests/ofproto-macros.at
> index 06f9b65..fabdb84 100644
> --- a/tests/ofproto-macros.at
> +++ b/tests/ofproto-macros.at
> @@ -8,7 +8,13 @@ m4_define([OFPROTO_START],
>    AT_CAPTURE_FILE([ovs-openflowd.log])
>    AT_CHECK(
>      [ovs-openflowd --detach --pidfile --enable-dummy --log-file dummy at br0 none --datapath-id=fedcba9876543210 $1],
> -     [0], [ignore], [ignore])
> +     [0], [], [stderr])
> +   AT_CHECK([[sed < stderr '
> +/vlog|INFO|opened log file/d
> +/openflowd|INFO|Open vSwitch version/d
> +/openflowd|INFO|OpenFlow protocol version/d
> +/ofproto|INFO|using datapath ID/d
> +/ofproto|INFO|datapath ID changed to fedcba9876543210/d']])
>  ])
>
>  m4_define([OFPROTO_STOP],
> --
> 1.7.4.4
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>



More information about the dev mailing list