[ovs-dev] [PATCH] xenserver: remove unneeded macro definitions

Andrew Evans aevans at nicira.com
Tue May 17 18:34:37 UTC 2011


Thanks, looks good to me.

On Mon, May 16, 2011 at 7:20 PM, Sajjad Lateef <slateef at nicira.com> wrote:
> The macro binsuffix is no longer needed. It has been replaced with
> kernel_flavor that is passed on the command line.
>
> The macro kernel_version is passed on the command line. Redefining
> the macro inside the spec file leads to build failures.
>
> Signed-off-by: Sajjad Lateef <slateef at nicira.com>
> ---
>  xenserver/openvswitch-xen.spec |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/xenserver/openvswitch-xen.spec b/xenserver/openvswitch-xen.spec
> index 47d07f5..7b6ad84 100644
> --- a/xenserver/openvswitch-xen.spec
> +++ b/xenserver/openvswitch-xen.spec
> @@ -24,10 +24,6 @@
>  # bump this when breaking compatibility with userspace
>  %define module_abi_version 0
>
> -# extract kernel type (xen or kdump)
> -%define binsuffix -%(echo '%{xen_version}' | sed -r 's/^.*[0-9]+//')
> -# kernel version string w/o kernel type
> -%define kernel_version %(echo '%{xen_version}' | sed -r 's/[a-z]+$//')
>  # build-supplemental-pack.sh requires this naming for kernel module packages
>  %define module_package modules-%{kernel_flavor}-%{kernel_version}
>
> --
> 1.7.2.5
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>



More information about the dev mailing list