[ovs-dev] [next 2/2] ofproto-dpif: Revalidate flows in some previously missed cases.

Ben Pfaff blp at nicira.com
Wed May 18 16:29:07 UTC 2011


Thanks, I pushed this.

On Tue, May 17, 2011 at 04:01:46PM -0700, Ethan Jackson wrote:
> Looks Good.
> 
> Ethan
> 
> On Tue, May 17, 2011 at 15:50, Ben Pfaff <blp at nicira.com> wrote:
> > Reported-by: Justin Pettit <jpettit at nicira.com>
> > Bug #5655.
> > ---
> > ?ofproto/ofproto-dpif.c | ? ?4 ++++
> > ?1 files changed, 4 insertions(+), 0 deletions(-)
> >
> > diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
> > index 0e4f8cb..26a0fbf 100644
> > --- a/ofproto/ofproto-dpif.c
> > +++ b/ofproto/ofproto-dpif.c
> > @@ -830,6 +830,8 @@ bundle_del_port(struct ofport_dpif *port)
> > ?{
> > ? ? struct ofbundle *bundle = port->bundle;
> >
> > + ? ?bundle->ofproto->need_revalidate = true;
> > +
> > ? ? list_remove(&port->bundle_node);
> > ? ? port->bundle = NULL;
> >
> > @@ -861,6 +863,7 @@ bundle_add_port(struct ofbundle *bundle, uint32_t ofp_port,
> > ? ? }
> >
> > ? ? if (port->bundle != bundle) {
> > + ? ? ? ?bundle->ofproto->need_revalidate = true;
> > ? ? ? ? if (port->bundle) {
> > ? ? ? ? ? ? bundle_del_port(port);
> > ? ? ? ? }
> > @@ -1029,6 +1032,7 @@ bundle_set(struct ofproto *ofproto_, void *aux,
> > ? ? ? ? ? ? }
> > ? ? ? ? } else {
> > ? ? ? ? ? ? bundle->bond = bond_create(s->bond);
> > + ? ? ? ? ? ?ofproto->need_revalidate = true;
> > ? ? ? ? }
> >
> > ? ? ? ? LIST_FOR_EACH (port, bundle_node, &bundle->ports) {
> > --
> > 1.7.4.4
> >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
> >



More information about the dev mailing list