[ovs-dev] [PATCH] ofproto-dpif: Fix argument in send_packet() call.

Ben Pfaff blp at nicira.com
Thu May 19 17:55:11 UTC 2011


Thank you for the review.  I pushed this commit.

On Wed, May 18, 2011 at 05:13:28PM -0700, Justin Pettit wrote:
> Looks good.
> 
> --Justin
> 
> 
> On May 18, 2011, at 4:46 PM, Ben Pfaff wrote:
> 
> > The second argument to send_packet() is an ODP port, not an OFP port, so
> > we need to use ODPP_LOCAL instead of OFPP_LOCAL.
> > ---
> > ofproto/ofproto-dpif.c |    2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
> > index 714cdf6..2f03dfd 100644
> > --- a/ofproto/ofproto-dpif.c
> > +++ b/ofproto/ofproto-dpif.c
> > @@ -1591,7 +1591,7 @@ handle_miss_upcall(struct ofproto_dpif *ofproto, struct dpif_upcall *upcall)
> >     /* Check with in-band control to see if this packet should be sent
> >      * to the local port regardless of the flow table. */
> >     if (connmgr_msg_in_hook(ofproto->up.connmgr, &flow, upcall->packet)) {
> > -        send_packet(ofproto, OFPP_LOCAL, upcall->packet);
> > +        send_packet(ofproto, ODPP_LOCAL, upcall->packet);
> >     }
> > 
> >     facet = facet_lookup_valid(ofproto, &flow);
> > -- 
> > 1.7.4.4
> > 
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
> 



More information about the dev mailing list