[ovs-dev] [cfm 1/7] cfm: Migrate cfm/show unixctl command to CFM module.

Ethan Jackson ethan at nicira.com
Fri May 20 21:04:21 UTC 2011


> I'd be more comfortable with the memory management if the cfm object
> had its own copy of the name, instead of relying on the client to keep
> it valid.

A future patch moves to this style of managing 'name'.  I probably
should pull it back into this one though.  I'll go ahead and do that.

> Any reason not to use an shash or hmap instead of a list?

The main reason is that the 'name' parameter of a cfm object is not
necessarily fixed.  It can change arbitrarily at any time for any
reason by the client.   I think an obvious solution to this problem is
to require 'name' in cfm_create and remove it from the globally
visible struct cfm object.  Thus it won't be mutable.  I'll write up
an incremental.

Ethan



More information about the dev mailing list