[ovs-dev] [cfm 1/7] cfm: Migrate cfm/show unixctl command to CFM module.
blp at nicira.com
Fri May 20 21:12:43 UTC 2011
On Fri, May 20, 2011 at 02:04:21PM -0700, Ethan Jackson wrote:
> > I'd be more comfortable with the memory management if the cfm object
> > had its own copy of the name, instead of relying on the client to keep
> > it valid.
> A future patch moves to this style of managing 'name'. I probably
> should pull it back into this one though. I'll go ahead and do that.
I noticed that later in the series.
For that reason, it doesn't matter to me.
> > Any reason not to use an shash or hmap instead of a list?
> The main reason is that the 'name' parameter of a cfm object is not
> necessarily fixed. It can change arbitrarily at any time for any
> reason by the client. I think an obvious solution to this problem is
> to require 'name' in cfm_create and remove it from the globally
> visible struct cfm object. Thus it won't be mutable. I'll write up
> an incremental.
Seems reasonable to me. Thanks.
More information about the dev