[ovs-dev] [PATCH 2/2] flow: flow_hash_symmetric_l4() don't hash UDP ports.

Ben Pfaff blp at nicira.com
Mon May 23 20:06:19 UTC 2011


On Mon, May 23, 2011 at 11:41:28AM -0700, Ethan Jackson wrote:
> There is no reason to believe that the source and destination ports
> will me symmetric in a bidirectional UDP stream.  This patch no

"will be"

> longer users them for symmetric hashing.

"uses them"

It would be good to document the rationale here in a comment.  As-is,
it seems likely that someone will eventually come along and say, "hey,
we can include UDP ports too!".

The code changes look fine.

Thanks,

Ben.



More information about the dev mailing list