[ovs-dev] [PATCH 2/2] flow: flow_hash_symmetric_l4() don't hash UDP ports.

Ethan Jackson ethan at nicira.com
Mon May 23 20:11:27 UTC 2011


Thanks for the reviews.

I added the following comment:
/* UDP source and destination port are not taken into account because they
 * will not necessarily be symmetric in a bidirectional flow. */

Ethan

On Mon, May 23, 2011 at 13:06, Ben Pfaff <blp at nicira.com> wrote:
> On Mon, May 23, 2011 at 11:41:28AM -0700, Ethan Jackson wrote:
>> There is no reason to believe that the source and destination ports
>> will me symmetric in a bidirectional UDP stream.  This patch no
>
> "will be"
>
>> longer users them for symmetric hashing.
>
> "uses them"
>
> It would be good to document the rationale here in a comment.  As-is,
> it seems likely that someone will eventually come along and say, "hey,
> we can include UDP ports too!".
>
> The code changes look fine.
>
> Thanks,
>
> Ben.
>



More information about the dev mailing list