[ovs-dev] [monitor 2/4] ofproto: Discontinue use of netdev_monitor.

Ethan Jackson ethan at nicira.com
Tue May 31 21:32:43 UTC 2011

On Fri, May 27, 2011 at 09:33, Ben Pfaff <blp at nicira.com> wrote:
> The change to ofproto_run() looks like it can't be right, because it
> uses 'error' and 'devname' without ever setting them.  (Once that's
> fixed, it can call update_port() directly instead of going through
> process_port_change(), and then process_port_change() can be inlined
> into ofproto_run() since it only has one caller left.)

Oops, pretty silly.  I'll just call update_port() directly using
netdev_get_name() instead of going through process_port_change().

Thanks, for the review.

More information about the dev mailing list