[ovs-dev] [pre-async 7/8] ofproto: Better abstract aggregate stats encoding and decoding.

Ben Pfaff blp at nicira.com
Tue May 31 23:50:22 UTC 2011


On Tue, May 31, 2011 at 12:52:35AM -0700, Justin Pettit wrote:
> On May 24, 2011, at 4:25 PM, Ben Pfaff wrote:
> 
> > -/* Creates an ofp_stats_msg with the given 'type' and 'body_len' bytes of space
> > - * allocated for the 'body' member.  Returns the first byte of the 'body'
> > +/* Creates an ofp_stats_request with the given 'type' and 'body_len' bytes of
> > + * space allocated for the 'body' member.  Returns the first byte of the 'body'
> >  * member. */
> > void *
> > ofputil_make_stats_request(size_t openflow_len, uint16_t ofpst_type,
> > @@ -1608,7 +1639,7 @@ put_stats_reply__(const struct ofp_stats_msg *request, struct ofpbuf *msg)
> >                 msg);
> 
> As mentioned in the previous patch, you'll need to update this comment.
> 
> > -/* Creates an stats reply message with the given 'type' and 'body_len' bytes of
> > +/* Creates an ofp_stats_reply with the given 'type' and 'body_len' bytes of
> >  * space allocated for the 'body' member.  Returns the first byte of the 'body'
> >  * member. */
> > void *
> 
> Same here for ofputil_make_stats_reply().

I updated them in the previous patch.

Thank you for the review.



More information about the dev mailing list