[ovs-dev] [PATCH 2/3] datapath: Drop useless WARN_ON_ONCE during flow conversion.

Jesse Gross jesse at nicira.com
Wed Nov 2 05:50:50 UTC 2011


This checks whether key_len is not zero but we set the key length
at the beginning of the function, so I don't see this as a useful
check.

Signed-off-by: Jesse Gross <jesse at nicira.com>
---
 datapath/flow.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/datapath/flow.c b/datapath/flow.c
index 95297a5..9e0b842 100644
--- a/datapath/flow.c
+++ b/datapath/flow.c
@@ -1143,7 +1143,6 @@ invalid:
 	error = -EINVAL;
 
 ok:
-	WARN_ON_ONCE(!key_len && !error);
 	*key_lenp = key_len;
 	return error;
 }
-- 
1.7.5.4




More information about the dev mailing list