[ovs-dev] [#8024 6/7] Support matching and modifying IP ECN bits.

[Ben Pfaff]

On Mon, Nov 07, 2011 at 10:33:09AM -0800, Justin Pettit wrote:
> Signed-off-by: Justin Pettit <jpettit at nicira.com>

In nicira-ext.h, is there value in adding NXAST_SET_NW_ECN given that
it could be set with NXAST_REG_LOAD without adding a new action?

On the comments for NXAST_SET_NW_ECN and NXM_NX_IP_ECN, it'd be nice
to note that the ECN is in the 2 low-order bits.

In meta-flow.c, we declare both dscp and ECN as 8 bits but it would be
more realistic to say that they are 6 and 2 bits, respectively.

I don't see why mf_is_value_valid() now allows the "wrong" bits in
MFF_IP_DSCP or MFF_IP_ECN to be set.

This should be "between 0 and 3", right?
> +.IP \fBmod_nw_ecn\fB:\fIecn\fR
> +Sets the IP ECN field to \fIecn\fR.  Valid values are between 0 and 4,
> +inclusive.