[ovs-dev] [#8024 4/7] Support matching IPv6 flow label.

Ben Pfaff blp at nicira.com
Mon Nov 7 21:00:06 UTC 2011


On Mon, Nov 07, 2011 at 12:37:46PM -0800, Justin Pettit wrote:
> On Nov 7, 2011, at 11:42 AM, Ben Pfaff wrote:
> 
> > On Mon, Nov 07, 2011 at 10:33:07AM -0800, Justin Pettit wrote:
> >> Signed-off-by: Justin Pettit <jpettit at nicira.com>
> > 
> > Would you mind humoring me by writing htonl(0) below:
> >> +    if (wc & FWW_IPV6_LABEL) {
> >> +        flow->ipv6_label = 0;
> >> +    }
> > 
> > and here too:
> > +    case MFF_IPV6_LABEL:
> > +        rule->wc.wildcards |= FWW_IPV6_LABEL;
> > +        rule->flow.ipv6_label = 0;
> > +        break;
> > +
> 
> Yes.  That's my preferred style, too.  Other places in those
> function don't do that conversion either.  I'll write up a patch to
> get those, too.

That's fine, thank you.



More information about the dev mailing list