[ovs-dev] [#8024 6/7] Support matching and modifying IP ECN bits.

Justin Pettit jpettit at nicira.com
Tue Nov 8 22:32:15 UTC 2011


On Nov 7, 2011, at 12:50 PM, Ben Pfaff wrote:

> On Mon, Nov 07, 2011 at 10:33:09AM -0800, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit <jpettit at nicira.com>
> 
> In nicira-ext.h, is there value in adding NXAST_SET_NW_ECN given that
> it could be set with NXAST_REG_LOAD without adding a new action?

Good point.  I dropped the new action to set ECN.

> On the comments for NXAST_SET_NW_ECN and NXM_NX_IP_ECN, it'd be nice
> to note that the ECN is in the 2 low-order bits.

Okay, done.

> In meta-flow.c, we declare both dscp and ECN as 8 bits but it would be
> more realistic to say that they are 6 and 2 bits, respectively.

I've switched that for ECN.  I don't think it works properly for DSCP, since the "active" part is in the most significant bits.

> I don't see why mf_is_value_valid() now allows the "wrong" bits in
> MFF_IP_DSCP or MFF_IP_ECN to be set.

Okay, fixed.

> This should be "between 0 and 3", right?
>> +.IP \fBmod_nw_ecn\fB:\fIecn\fR
>> +Sets the IP ECN field to \fIecn\fR.  Valid values are between 0 and 4,
>> +inclusive.


Whoops.  This is dropped now that I've removed mod_nw_ecn.

I'll send out a revised version of this patch in a bit.

--Justin





More information about the dev mailing list