[ovs-dev] [#8024v2 2/5] Don't overload IP TOS with the frag matching bits.

Jesse Gross jesse at nicira.com
Wed Nov 9 17:02:14 UTC 2011


On Tue, Nov 8, 2011 at 11:15 PM, Justin Pettit <jpettit at nicira.com> wrote:
> On Nov 8, 2011, at 8:13 PM, Jesse Gross wrote:
>
>> On Tue, Nov 8, 2011 at 4:24 PM, Ben Pfaff <blp at nicira.com> wrote:
>>> On Tue, Nov 08, 2011 at 03:57:29PM -0800, Justin Pettit wrote:
>>>> This will be useful later when we add support for matching the ECN bits
>>>> within the TOS field.
>>>>
>>>> Signed-off-by: Justin Pettit <jpettit at nicira.com>
>>>
>>> I think that these |=s can become =s:
>>
>> There's some instances of this in the userspace flow_extract() as well.
>
> I think there was only one, since the flag behavior is slightly different between userspace and kernel.  You can double check my work in the incremental, though.

Yes, I think there's only one.  I didn't really count; by "some" I
meant "an indeterminate number" which I think one qualifies for :)



More information about the dev mailing list