[ovs-dev] [#8024v2 3/5] Support matching and modifying IP ECN bits.

Jesse Gross jesse at nicira.com
Wed Nov 9 17:19:05 UTC 2011


On Wed, Nov 9, 2011 at 12:43 AM, Justin Pettit <jpettit at nicira.com> wrote:
> On Nov 8, 2011, at 10:56 PM, Jesse Gross wrote:
>
>> I think after this patch we actually do need to update the comment in
>> datapath/flow.h on tos (it talks about DSCP).  Also that block of
>> comments in misaligned.
>
> Okay.  Updated.
>
>> I also discovered that there is ipv4_change_dsfield() function that
>> you could use instead of set_ip_tos() and also does the checksum a
>> little more efficiently.
>
> Cool.  I've attached a new incremental for these cleanups to the end of this message.

Looks good, thanks.



More information about the dev mailing list