[ovs-dev] [#8024v2 4/5] Support matching and modifying IP TTL.

Justin Pettit jpettit at nicira.com
Wed Nov 9 20:00:46 UTC 2011


On Nov 9, 2011, at 11:53 AM, Jesse Gross wrote:

> On Wed, Nov 9, 2011 at 11:21 AM, Justin Pettit <jpettit at nicira.com> wrote:
>> diff --git a/lib/odp-util.c b/lib/odp-util.c
>> index 3703844..4b0cee4 100644
>> --- a/lib/odp-util.c
>> +++ b/lib/odp-util.c
>> @@ -390,7 +390,7 @@ format_odp_key_attr(const struct nlattr *a, struct ds *ds)
>>                       ",tos=%#"PRIx8",ttl=%"PRIu8",frag=%s)",
>>                       src_str, dst_str, ntohl(ipv6_key->ipv6_label),
>>                       ipv6_key->ipv6_proto, ipv6_key->ipv6_tos,
>> -                      ipv6_key->ipv6_ttl,
>> +                      ipv6_key->ipv6_hop_limit,
> 
> Should we make the "ttl=" be "hop_limit=" as well?
> 
> Otherwise, looks good.


It wouldn't be a review cycle if I didn't have to rewrite all the tests.  :-)

I've updated it.  Thanks.

--Justin





More information about the dev mailing list