[ovs-dev] [PATCH] stream: Fix uninitialized values in stream_init().

[Jari Sundell]

On Thu, Nov 10, 2011 at 1:20 AM, Ben Pfaff <blp at nicira.com> wrote:
> OK, great, so what are those issues?
>
> On Wed, Nov 09, 2011 at 05:12:13PM +0900, Jari Sundell wrote:
>> The attached file shows output from dpctl dump-flows for the working,
>> and non-working revisions. I think the mod_dl_dst part might have been
>> a red herring, as it seems there's some issues with connections
>> between some services even before a vm is brought up and flows with
>> mod_dl_dst are inserted.

Sorry, the other issues were unrelated. (The joys of working with
several in-development codebases that all interact)

In any case, it seems pretty clear that mod_dl_dst/src is the culprit
here, ran the bad revision first with all mod_dl_src/dst flows having
the action removed but otherwise intact. When starting a vm the
packets it sent showed up in wireshark as they should (besides the mac
address, obviously).

Then I added back the mod_dl_dst/src actions, and the packets go missing.

Jari Sundell

=== 4edb9ae90 (buggy rev) translated package shows up in wireshark ===
ovs-ofctl add-flow br0
priority=3,idle_timeout=300,tcp,table=6,in_port=4,dl_src=00:ff:f1:46:69:7d,dl_dst=88:43:e1:42:4f:60,nw_src=192.168.2.217,tp_src=39017,actions=mod_dl_dst:00:1e:0b:ea:fb:7e,mod_nw_dst:192.168.2.23,mod_tp_dst:9002,local
ovs-ofctl add-flow br0
priority=3,idle_timeout=300,tcp,table=7,in_port=local,dl_src=00:1e:0b:ea:fb:7e,dl_dst=00:ff:f1:46:69:7d,nw_dst=192.168.2.217,tp_dst=39017,actions=mod_dl_src:88:43:e1:42:4f:60,mod_nw_src:169.254.169.254,mod_tp_src:80,output:4

=== 4edb9ae90 (buggy rev) package goes missing ===
ovs-ofctl add-flow br0
priority=3,idle_timeout=300,tcp,table=6,in_port=3,dl_src=00:ff:f1:ea:0d:3e,dl_dst=88:43:e1:42:4f:60,nw_src=192.168.2.175,tp_src=53831,actions=mod_nw_dst:192.168.2.23,mod_tp_dst:9002,local
ovs-ofctl add-flow br0
priority=3,idle_timeout=300,tcp,table=7,in_port=local,dl_src=00:1e:0b:ea:fb:7e,dl_dst=00:ff:f1:ea:0d:3e,nw_dst=192.168.2.175,tp_dst=53831,actions=mod_nw_src:169.254.169.254,mod_tp_src:80,output:3'
=> true.

=== 4edb9ae90 (buggy rev) after adding a vm, no mod_dl_dst actions ===

in_port(2),eth(src=00:ff:f1:51:50:e7,dst=88:43:e1:42:4f:60),eth_type(0x0806),arp(sip=192.168.2.189,tip=192.168.2.1,op=1,sha=00:ff:f1:51:50:e7,tha=00:00:00:00:00:00),
packets:0, bytes:0, used:never, actions:1
in_port(0),eth(src=00:1e:0b:ea:fb:7e,dst=88:43:e1:42:4f:60),eth_type(0x0800),ipv4(src=192.168.2.23,dst=192.168.1.156,proto=6,tos=16),tcp(src=22,dst=50981),
packets:894, bytes:2022540, used:0.141s, actions:1
in_port(1),eth(src=88:43:e1:42:4f:60,dst=00:1e:0b:ea:fb:7e),eth_type(0x0800),ipv4(src=192.168.1.156,dst=192.168.2.23,proto=6,tos=16),tcp(src=50981,dst=22),
packets:1238, bytes:100068, used:0.131s, actions:0
in_port(1),eth(src=88:43:e1:42:4f:62,dst=01:80:c2:00:00:00),
packets:85, bytes:5100, used:1.551s, actions:drop
in_port(2),eth(src=00:ff:f1:51:50:e7,dst=88:43:e1:42:4f:60),eth_type(0x0800),ipv4(src=192.168.2.189,dst=169.254.169.254,proto=6,tos=0),tcp(src=39955,dst=80),
packets:0, bytes:0, used:never,
actions:set(ipv4(src=192.168.2.189,dst=192.168.2.23,proto=6,tos=0)),set(tcp(src=39955,dst=9002)),0
in_port(1),eth(src=88:43:e1:42:4f:60,dst=00:ff:f1:51:50:e7),eth_type(0x0806),arp(sip=192.168.2.1,tip=192.168.2.189,op=2,sha=88:43:e1:42:4f:60,tha=00:ff:f1:51:50:e7),
packets:0, bytes:0, used:never, actions:2
in_port(1),eth(src=88:43:e1:42:4f:60,dst=00:1e:0b:ea:fb:7e),eth_type(0x0800),ipv4(src=192.168.1.156,dst=192.168.2.23,proto=6,tos=16),tcp(src=50977,dst=22),
packets:82, bytes:7332, used:0.141s, actions:0
in_port(0),eth(src=00:1e:0b:ea:fb:7e,dst=88:43:e1:42:4f:60),eth_type(0x0800),ipv4(src=192.168.2.23,dst=192.168.1.156,proto=6,tos=16),tcp(src=22,dst=50977),
packets:41, bytes:5874, used:0.141s, actions:1