[ovs-dev] [mirror 02/13] ofproto-dpif: Remove duplicate VLAN logic.

Justin Pettit jpettit at nicira.com
Fri Nov 11 02:51:39 UTC 2011


On Oct 26, 2011, at 10:09 AM, Ben Pfaff wrote:

> @@ -4810,6 +4821,7 @@ is_admissible(struct ofproto_dpif *ofproto, const struct flow *flow,
> {

The comment for is_admissable() seems out of date.  It refers to "in_portp", but I'm guessing it should be referring to "in_bundlep".  Also, I think you'll want to update the comment to not refer to flow_get_vlan() anymore, since you've deleted it.

Otherwise, looks good.

--Justin





More information about the dev mailing list