[ovs-dev] [PATCH] Implement a new port setting "other-config:priority-tags".

Ben Pfaff blp at nicira.com
Fri Nov 18 01:12:35 UTC 2011


On Thu, Nov 17, 2011 at 05:10:14PM -0800, Justin Pettit wrote:
> On Nov 17, 2011, at 4:01 PM, Ben Pfaff wrote:
> 
> > +            have a 802.1Q header if it has a nonzero VLAN ID.
> 
> In other places, "an 802.1Q" is used instead of "a 802.1Q".

OK, I did s/a/an/ here.

> > +            Any packet with an 802.1Q header with a nonzero VLAN ID that
> > +            ingresses on an access port is dropped, regardless of whether the
> > +            VLAN ID in the header is the access port's VLAN ID.
> > +            (Priority-tagged frames are allowed on ingress.)
> 
> Do you think it's worth forward-referencing the description of
> priority-tagged frames?  Or a parenthetical "(those with a VLAN ID
> of zero)"?

I decided to just delete the parenthetical since "with an 802.1Q
header with a nonzero VLAN ID" already covers that case.

Thanks,

Ben.



More information about the dev mailing list