[ovs-dev] [PATCH] datapath: Scope global symbols with ovs_ prefix.

Jesse Gross jesse at nicira.com
Tue Nov 22 19:15:32 UTC 2011


On Tue, Nov 22, 2011 at 10:58 AM, Stephen Hemminger
<shemminger at vyatta.com> wrote:
> On Tue, 22 Nov 2011 10:34:04 -0800
> Ben Pfaff <blp at nicira.com> wrote:
>
>> On Tue, Nov 22, 2011 at 10:30:05AM -0800, Jesse Gross wrote:
>> > OVS has quite a few global symbols that should be scoped with a
>> > prefix to prevent collisions with other modules in the kernel.
>> >
>> > Suggested-by: Stephen Hemminger <shemminger at vyatta.com>
>> > Signed-off-by: Jesse Gross <jesse at nicira.com>
>>
>> Acked-by: Ben Pfaff <blp at nicira.com>
>>
>> I didn't apply or build this patch, so my ack is based on a visual
>> skim only.
>>
>> We could rename some other identifiers too (e.g. sw_flow -> ovs_flow)
>> but since they have internal linkage or no linkage it's not as
>> important.
>
> Only global symbols need it. You can keep shorter name on statics
> and inlines.

I did only the global symbols in this patch (plus a few that would
have been very inconsistent otherwise).  There's probably a few things
that are worth renaming for other reasons but I figure we can do that
separately in the future.

Thanks for the review guys, I pushed this patch.



More information about the dev mailing list