[ovs-dev] [TCP_CRR 3/6] dpif-linux: Use poll() internally in dpif_linux_recv().

Ben Pfaff blp at nicira.com
Mon Nov 28 17:28:57 UTC 2011


On Thu, Nov 24, 2011 at 09:28:38AM -0800, Justin Pettit wrote:
> On Nov 22, 2011, at 3:12 PM, Ben Pfaff wrote:
> 
> >     /* Upcall messages. */
> >     struct nl_sock *upcall_socks[N_UPCALL_SOCKS];
> > -    int last_read_upcall;
> > +    uint32_t nonempty_socks;
> 
> I think it would be helpful to point out that this is a mask--either
> through a comment or appending "_mask" to the name.

I renamed "nonempty_socks" to "ready_mask" and added a comment.

Thanks,

Ben.



More information about the dev mailing list