[ovs-dev] [PATCH 2/2] odp-util: Move commit_odp_actions() from ofproto-dpif.

Ben Pfaff blp at nicira.com
Mon Nov 28 23:40:44 UTC 2011


On Mon, Nov 28, 2011 at 02:43:15PM -0800, Ethan Jackson wrote:
> In an effort to simplify ofproto-dpif, this commit moves the
> definition of commit_odp_actions() to odp-util.

I think that we could improve the comment on commit_odp_actions().
Something like this:

    If any of the flow key data that ODP actions can modify are
    different in 'base' and 'flow', appends ODP actions to
    'odp_actions' that change the flow key from 'base' into 'flow',
    and then changes 'base' the same way.

Thanks,

Ben.



More information about the dev mailing list