[ovs-dev] [PATCH] ofp-parse: Remove write-only variable in parse_ofp_flow_mod_str().

[Ben Pfaff]

Thanks, I pushed this.

On Mon, Oct 03, 2011 at 09:30:21AM -0700, Justin Pettit wrote:
> Looks good.
> 
> --Justin
> 
> 
> On Oct 3, 2011, at 9:29 AM, Ben Pfaff wrote:
> 
> > ---
> > lib/ofp-parse.c |    4 ----
> > 1 files changed, 0 insertions(+), 4 deletions(-)
> > 
> > diff --git a/lib/ofp-parse.c b/lib/ofp-parse.c
> > index fd0a72e..6b1cfa0 100644
> > --- a/lib/ofp-parse.c
> > +++ b/lib/ofp-parse.c
> > @@ -593,11 +593,9 @@ parse_ofp_flow_mod_str(struct list *packets, enum nx_flow_format *cur_format,
> > {
> >     enum nx_flow_format min_format, next_format;
> >     struct cls_rule rule_copy;
> > -    struct ofpbuf actions;
> >     struct ofpbuf *ofm;
> >     struct ofputil_flow_mod fm;
> > 
> > -    ofpbuf_init(&actions, 64);
> >     parse_ofp_str(&fm, command, string, verbose);
> > 
> >     min_format = ofputil_min_flow_format(&fm.cr);
> > @@ -622,8 +620,6 @@ parse_ofp_flow_mod_str(struct list *packets, enum nx_flow_format *cur_format,
> > 
> >     ofm = ofputil_encode_flow_mod(&fm, *cur_format, *flow_mod_table_id);
> >     list_push_back(packets, &ofm->list_node);
> > -
> > -    ofpbuf_uninit(&actions);
> > }
> > 
> > /* Similar to parse_ofp_flow_mod_str(), except that the string is read from
> > -- 
> > 1.7.4.4
> > 
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
>