[ovs-dev] [learn bugs 1/5] meta-flow: Fix icmp_code field's wildcard bit.

[Justin Pettit]

Sorry for the delay.  Looks good.

--Justin


On Sep 27, 2011, at 1:36 PM, Ben Pfaff wrote:

> This bug caused any NXM flow that matched both ICMP code and ICMP type to
> be rejected with NXBRC_NXM_DUP_TYPE.
> ---
> lib/meta-flow.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/meta-flow.c b/lib/meta-flow.c
> index 140f902..6d2bfbd 100644
> --- a/lib/meta-flow.c
> +++ b/lib/meta-flow.c
> @@ -268,7 +268,7 @@ static const struct mf_field mf_fields[MFF_N_IDS] = {
>     }, {
>         MFF_ICMP_CODE, "icmp_code", NULL,
>         MF_FIELD_SIZES(u8),
> -        MFM_NONE, FWW_TP_SRC,
> +        MFM_NONE, FWW_TP_DST,
>         MFS_DECIMAL,
>         MFP_ICMP_ANY,
>         NXM_OF_ICMP_CODE,
> -- 
> 1.7.4.4
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev