[ovs-dev] [PATCH 1/2] odp-util: Use nl_parse_nested() to simplify format_odp_sample_action().

Ben Pfaff blp at nicira.com
Tue Oct 4 20:22:38 UTC 2011


---
 lib/odp-util.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/lib/odp-util.c b/lib/odp-util.c
index d97d30c..7f5158f 100644
--- a/lib/odp-util.c
+++ b/lib/odp-util.c
@@ -98,16 +98,13 @@ format_odp_sample_action(struct ds *ds, const struct nlattr *attr)
         [OVS_SAMPLE_ATTR_ACTIONS] = { .type = NL_A_NESTED }
     };
     struct nlattr *a[ARRAY_SIZE(ovs_sample_policy)];
-    struct ofpbuf buf;
     double percentage;
     const struct nlattr *nla_acts;
     int len;
 
     ds_put_cstr(ds, "sample");
 
-    ofpbuf_use_const(&buf, nl_attr_get(attr), nl_attr_get_size(attr));
-    if (!nl_policy_parse(&buf, 0, ovs_sample_policy, a,
-                            ARRAY_SIZE(ovs_sample_policy))) {
+    if (!nl_parse_nested(attr, ovs_sample_policy, a, ARRAY_SIZE(a))) {
         ds_put_cstr(ds, "(error)");
         return;
     }
-- 
1.7.4.4




More information about the dev mailing list