[ovs-dev] [PATCH] datapath: Strip down vport interface - ifIndex.

Pravin Shelar pshelar at nicira.com
Thu Oct 6 02:12:08 UTC 2011


On Wed, Oct 5, 2011 at 6:45 PM, Jesse Gross <jesse at nicira.com> wrote:
> On Wed, Oct 5, 2011 at 2:21 PM, Pravin B Shelar <pshelar at nicira.com> wrote:
>> diff --git a/include/openvswitch/datapath-protocol.h b/include/openvswitch/datapath-protocol.h
>> index 3db960a..80a76d6 100644
>> --- a/include/openvswitch/datapath-protocol.h
>> +++ b/include/openvswitch/datapath-protocol.h
>> @@ -230,14 +230,11 @@ enum ovs_vport_cmd {
>>  * @OVS_VPORT_ATTR_STATS: A &struct ovs_vport_stats giving statistics for
>>  * packets sent or received through the vport.
>>  * @OVS_VPORT_ATTR_ADDRESS: A 6-byte Ethernet address for the vport.
>> - * @OVS_VPORT_ATTR_IFINDEX: ifindex of the underlying network device, if any.
>>  *
>>  * These attributes follow the &struct ovs_header within the Generic Netlink
>>  * payload for %OVS_VPORT_* commands.
>>  *
>>  * All attributes applicable to a given port are present in notifications.
>> - * This means that, for example, a vport that has no corresponding network
>> - * device would omit %OVS_VPORT_ATTR_IFINDEX.
>
> You can remove the sentence above this as well, since all attributes
> are now included all the time.
>
> Otherwise looks good:
> Acked-by: Jesse Gross <jesse at nicira.com>
>
Thanks, pushed to master.



More information about the dev mailing list