[ovs-dev] [bug 7759 03/11] dpif-netdev: Simplify code by removing dpif_netdev_validate_actions().

[Ben Pfaff]

On Tue, Oct 11, 2011 at 10:26:09AM -0700, Jesse Gross wrote:
> On Wed, Oct 5, 2011 at 11:27 AM, Ben Pfaff <blp at nicira.com> wrote:
> > dpif_netdev_validate_actions() existed for three reasons. ??First, it checked
> > that the actions were well-formed and valid. ??This isn't really necessary,
> > because the actions are built internally by ofproto-dpif and will always be
> > well-formed. ??(If not, that's a bug in ofproto-dpif.) ??Second, it checks
> > whether the actions will modify (mutate) the data in the packet and reports
> > that to the caller, which can use it to optimize what it does. ??However,
> > the only caller that used this was dpif_netdev_execute(), which is not a
> > fast-path (if dpif-netdev can be said to have a fast path at all).
> >
> > Third, dpif_netdev_validate_actions() rejects certain actions that
> > dpif-netdev does not implement: OVS_ACTION_ATTR_SET_TUNNEL,
> > OVS_ACTION_ATTR_SET_PRIORITY, and OVS_ACTION_ATTR_POP_PRIORITY. ??However,
> > this doesn't really seem necessary to me. ??First, dpif-netdev can't support
> > tunnels in any case, so OVS_ACTION_ATTR_SET_TUNNEL shouldn't come up.
> > Second, the priority actions just aren't important enough to worry about;
> > they only affect QoS, which isn't really important with dpif-netdev since
> > it's going to be slow anyway.
> >
> > So this commit just drops dpif_netdev_validate_actions() entirely.
> 
> I think this is a good change.  Can you push it soon (along with the
> next patch when I get to it)?  I think that it will help out Pravin so
> that he doesn't have to spend time updating this function for his
> patch set.

I pushed the first four commits.