[ovs-dev] [bug 7759 10/11] datapath-protocol: Use Linux kernel types directly.

Jesse Gross jesse at nicira.com
Tue Oct 11 19:34:04 UTC 2011


On Wed, Oct 5, 2011 at 11:27 AM, Ben Pfaff <blp at nicira.com> wrote:
> We want datapath-protocol.h to be acceptable as a Linux kernel header, so
> it must use Linux kernel types and must not have references to Open vSwitch
> symbols or header files.  This commit primarily makes that change to
> datapath-protocol.h.
>
> At the same time, at least for now we also want datapath-protocol.h to be
> usable on non-Linux platforms, so we need some kind of compatiblity.  Thus,
> this commit also introduces a <linux/types.h> header file that defines the
> necessary Linux kernel types on non-Linux platforms.
>
> In turn, this requires openvswitch/types.h to use the Linux types directly
> for ovs_be<N>; otherwise, sparse complains because now __be<N> and
> ovs_be<N> are incompatible from its perspective, so this commit makes that
> change too.
>
> I don't have a non-Linux kernel platform readily available, so I only
> tested the non-Linux part of the linux/types.h substitute by forcing that
> case to be triggered with #if 0.  It worked, except for errors in actual
> Linux kernel headers included explicitly from OVS source files, so I think
> it's likely to work in practice.
>
> Bug #7559.
> Signed-off-by: Ben Pfaff <blp at nicira.com>

Acked-by: Jesse Gross <jesse at nicira.com>



More information about the dev mailing list