[ovs-dev] [optimize 05/13] ofproto-dpif: Move DHCP in-band control special case into xlate_actions().
ethan at nicira.com
Wed Oct 12 19:26:07 UTC 2011
Looks good, thanks.
On Wed, Oct 12, 2011 at 11:31, Ben Pfaff <blp at nicira.com> wrote:
> On Tue, Oct 11, 2011 at 07:09:20PM -0700, Ethan Jackson wrote:
>> This seems fine to me.
>> I think the commit message could use more explanation of why this
>> patch was written. Is it simply to clean up the code, or is there
>> some other reason which is non-obvious to me?
> OK, I added this to the commit message:
> This eliminates an extra round trip to the kernel for this special case
> and keeps all the flow translation logic in one place.
More information about the dev