[ovs-dev] [PATCH] bond: Demote active-backup WARN to DBG.

Ben Pfaff blp at nicira.com
Mon Oct 17 19:22:52 UTC 2011


Thanks, I pushed this.

On Mon, Oct 17, 2011 at 11:50:10AM -0700, Ethan Jackson wrote:
> Looks good.
> 
> Ethan
> 
> On Mon, Oct 17, 2011 at 11:43, Ben Pfaff <blp at nicira.com> wrote:
> > This log message comes up for packets that are flooded through the network.
> > If the upstream switch doesn't realize that an active-backup bond is in
> > use, and there is significant packet flooding in the network, then we will
> > get a lot of these messages.
> >
> > (This message doesn't get logged for multicast or broadcast packets since
> > they get dropped earlier in the function.)
> >
> > Reported-by: Eivind Bulie Haanaes
> > Bug-report: http://forums.citrix.com/thread.jspa?messageID=1589125
> > CC: Paul Fazzone <pfazzone at nicira.com>
> > ---
> > ?lib/bond.c | ? ?6 +++---
> > ?1 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/lib/bond.c b/lib/bond.c
> > index 1f2b641..73ee814 100644
> > --- a/lib/bond.c
> > +++ b/lib/bond.c
> > @@ -585,9 +585,9 @@ bond_check_admissibility(struct bond *bond, const void *slave_,
> > ? ? ? ? if (bond->active_slave != slave) {
> > ? ? ? ? ? ? static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
> >
> > - ? ? ? ? ? ?VLOG_WARN_RL(&rl, "active-backup bond received packet on backup"
> > - ? ? ? ? ? ? ? ? ? ? ? ? " slave (%s) destined for " ETH_ADDR_FMT,
> > - ? ? ? ? ? ? ? ? ? ? ? ? slave->name, ETH_ADDR_ARGS(eth_dst));
> > + ? ? ? ? ? ?VLOG_DBG_RL(&rl, "active-backup bond received packet on backup"
> > + ? ? ? ? ? ? ? ? ? ? ? ?" slave (%s) destined for " ETH_ADDR_FMT,
> > + ? ? ? ? ? ? ? ? ? ? ? ?slave->name, ETH_ADDR_ARGS(eth_dst));
> > ? ? ? ? ? ? return BV_DROP;
> > ? ? ? ? }
> > ? ? }
> > --
> > 1.7.4.4
> >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
> >



More information about the dev mailing list