[ovs-dev] [link_resets 3/7] vswitchd: Remove iface_get_carrier().

Ben Pfaff blp at nicira.com
Mon Oct 17 20:34:52 UTC 2011


On Mon, Oct 17, 2011 at 01:15:00PM -0700, Ethan Jackson wrote:
> On Mon, Oct 17, 2011 at 13:10, Ben Pfaff <blp at nicira.com> wrote:
> > On Mon, Oct 17, 2011 at 12:10:20PM -0700, Ethan Jackson wrote:
> >> It has only one caller, and doesn't improve the code's readability.
> >
> > Looks OK to me. ?Might be better with a variable instead of with lots
> > of line wrapping.
> 
> One of the next patches in the series does introduces a variable, so I
> think I'll leave it in this one.

OK.



More information about the dev mailing list