[ovs-dev] [PATCH] types: Fix endianness check.

Ben Pfaff blp at nicira.com
Tue Oct 18 17:24:46 UTC 2011


Thanks for the review.  I pushed this to master and branch-1.3.

On Tue, Oct 18, 2011 at 10:21:11AM -0700, Justin Pettit wrote:
> Looks good.  Since there's still some stuff landing in branch-1.3
> (such as STP), I'm guessing this is worth including, too.  If you
> agree, can you do that when you commit?
> 
> Thanks,
> 
> --Justin
> 
> 
> On Oct 18, 2011, at 9:49 AM, Ben Pfaff wrote:
> 
> > The Linux headers only check endianness if __CHECK_ENDIAN__ is declared.
> > We want that, so turn it on.
> > ---
> > include/linux/types.h |    5 +++++
> > 1 files changed, 5 insertions(+), 0 deletions(-)
> > 
> > diff --git a/include/linux/types.h b/include/linux/types.h
> > index 13112e8..fb05744 100644
> > --- a/include/linux/types.h
> > +++ b/include/linux/types.h
> > @@ -29,6 +29,11 @@
> > /* With some combinations of kernel and userspace headers, including both
> >  * <sys/types.h> and <linux/types.h> only works if you do so in that order, so
> >  * force it.  */
> > +
> > +#ifdef __CHECKER__
> > +#define __CHECK_ENDIAN__
> > +#endif
> > +
> > #include <sys/types.h>
> > #include_next <linux/types.h>
> > #else  /* no <linux/types.h> */
> > -- 
> > 1.7.4.4
> > 
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
> 



More information about the dev mailing list