[ovs-dev] [tunnels2 1/5] datapath: Reject attempts to change vport type with OVS_VPORT_CMD_SET.

Jesse Gross jesse at nicira.com
Tue Oct 18 17:47:55 UTC 2011


On Mon, Oct 17, 2011 at 3:13 PM, Ben Pfaff <blp at nicira.com> wrote:
> Until now this has just silently failed, but it seems to me like we should
> actively reject it.
>
> Signed-off-by: Ben Pfaff <blp at nicira.com>

This makes sense but it seems to me that there are plenty of other
things that fall into the category of invalid but silently ignored.
With vports, there are conflicting names and port numbers, something
similar for datapaths, and everywhere things like stats that shouldn't
be set.

I think this one is probably the worst and it's a step in the right
direction so:
Acked-by: Jesse Gross <jesse at nicira.com>



More information about the dev mailing list