[ovs-dev] [tunnels2 2/5] datapath: Fix tunnel reconfiguration that does not change key data.

[Jesse Gross]

On Mon, Oct 17, 2011 at 3:13 PM, Ben Pfaff <blp at nicira.com> wrote:
> Without this commit, a pair of commands like
>    ovs-dpctl add-if br0 gre0,type=gre,remote_ip=192.168.5.2,csum=true
>    ovs-dpctl set-if br0 gre0,csum=false
> would result in a csum of "true" for gre0, that is, the second command
> would silently have no effect.  This could also happen when the key data
> (such as remote_ip) changed but the port hash just happened to have the
> same value.
>
> This also fixes a small kernel memory leak in this case.
>
> An upcoming commit implements the "ovs-dpctl set-if" command mentioned
> above.
>
> Signed-off-by: Ben Pfaff <blp at nicira.com>

Good catch, that's a nasty bug.

Acked-by: Jesse Gross <jesse at nicira.com>

I'm going to look at Pravin's patch next but I wanted to get to the
bug fixes first.