[ovs-dev] [learn bugs 4/5] learn: Check learn actions after parsing in learn_parse().

Ben Pfaff blp at nicira.com
Tue Oct 18 20:42:38 UTC 2011


Maybe.  The rest are much simpler, though, and I haven't had trouble
with them in practice the way I have had with "learn".

On Tue, Oct 18, 2011 at 12:52:53PM -0700, Ethan Jackson wrote:
> Does it make sense to do something like this for the other complex
> actions we have (bundle, autopath, multipath, etc)?
> 
> Ethan
> 
> On Tue, Sep 27, 2011 at 13:36, Ben Pfaff <blp at nicira.com> wrote:
> > learn_parse() and learn_check() are supposed to apply the same checks, but
> > they are implemented very differently. ?It seems best to have learn_parse()
> > actually call learn_check() just to be sure.
> >
> > This would have caught the bug fixed in the previous commit, because
> > the tests actually contain instances of "learn" actions that trigger the
> > bug, but the tests only parsed the actions without ever doing anything
> > that checked them (like sending them to ovs-vswitchd over OpenFlow).



More information about the dev mailing list