[ovs-dev] [PATCH] tests: Fix intermittent failure in ovs-monitor-ipsec test.

Jesse Gross jesse at nicira.com
Thu Oct 27 04:37:58 UTC 2011


On Wed, Oct 26, 2011 at 9:23 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Wed, Oct 26, 2011 at 09:19:20PM -0700, Jesse Gross wrote:
>> The ovs-monitor-ipsec test waits for a specific number of lines
>> of output before doing a comparison to the correct values.  However,
>> some copy and pasted code did not update the number of lines to
>> look for resulting in a race condition where the comparison could
>> happen before the script finished running.
>
> Oops.  Sorry about that.
>
> (If you have a suggestion for a better way to do this, I'm all ears.)
>
> Your patch looks good to me.

Thanks, I pushed this.

I guess we could use a grep based approach rather than line count.  I
don't know whether that is any better though.



More information about the dev mailing list