[ovs-dev] [PATCH] ofp-print: Pretty-print payloads in all error messages, except "hello"s.

Ben Pfaff blp at nicira.com
Thu Oct 27 17:45:46 UTC 2011


Thanks, I pushed this.

On Fri, Oct 21, 2011 at 06:55:56PM -0700, Ethan Jackson wrote:
> Looks good.
> 
> Ethan
> 
> On Fri, Sep 30, 2011 at 11:01, Ben Pfaff <blp at nicira.com> wrote:
> > This function was only pretty-printing "bad request" error payloads. ?I
> > don't know why. ?It makes sense to pretty-print all of them except for
> > "hello" messages, which already have their own special cases.
> >
> > Suggestion #7369.
> > Suggested-by: Reid Price <reid at nicira.com>
> > ---
> > ?lib/ofp-print.c | ? ?6 +-----
> > ?1 files changed, 1 insertions(+), 5 deletions(-)
> >
> > diff --git a/lib/ofp-print.c b/lib/ofp-print.c
> > index a9f90df..aa1a31f 100644
> > --- a/lib/ofp-print.c
> > +++ b/lib/ofp-print.c
> > @@ -947,15 +947,11 @@ ofp_print_error_msg(struct ds *string, const struct ofp_error_msg *oem)
> > ? ? ? ? ds_put_printable(string, payload, payload_len);
> > ? ? ? ? break;
> >
> > - ? ?case OFPET_BAD_REQUEST:
> > + ? ?default:
> > ? ? ? ? s = ofp_to_string(payload, payload_len, 1);
> > ? ? ? ? ds_put_cstr(string, s);
> > ? ? ? ? free(s);
> > ? ? ? ? break;
> > -
> > - ? ?default:
> > - ? ? ? ?ds_put_hex_dump(string, payload, payload_len, 0, true);
> > - ? ? ? ?break;
> > ? ? }
> > ?}
> >
> > --
> > 1.7.4.4
> >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
> >



More information about the dev mailing list