[ovs-dev] [PATCH] ofproto: Add OFPC_QUEUE_STATS to switch feature reply.

Ben Pfaff blp at nicira.com
Sat Oct 29 17:08:42 UTC 2011


Open vSwitch has supported queue stats for a long time, but we forgot to
set the OFPC_QUEUE_STATS bit in the switch features reply to show that they
are supported.  This fixes it.
---
 ofproto/ofproto.c |    2 +-
 tests/ofproto.at  |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index 7543e11..9a302d5 100644
--- a/ofproto/ofproto.c
+++ b/ofproto/ofproto.c
@@ -1647,7 +1647,7 @@ handle_features_request(struct ofconn *ofconn, const struct ofp_header *oh)
     osf->n_buffers = htonl(pktbuf_capacity());
     osf->n_tables = ofproto->n_tables;
     osf->capabilities = htonl(OFPC_FLOW_STATS | OFPC_TABLE_STATS |
-                              OFPC_PORT_STATS);
+                              OFPC_PORT_STATS | OFPC_QUEUE_STATS);
     if (arp_match_ip) {
         osf->capabilities |= htonl(OFPC_ARP_MATCH_IP);
     }
diff --git a/tests/ofproto.at b/tests/ofproto.at
index 71cfb14..e430800 100644
--- a/tests/ofproto.at
+++ b/tests/ofproto.at
@@ -12,7 +12,7 @@ AT_CHECK([ovs-ofctl -vANY:ANY:WARN show br0], [0], [stdout])
 AT_CHECK([STRIP_XIDS stdout], [0], [dnl
 OFPT_FEATURES_REPLY: ver:0x1, dpid:fedcba9876543210
 n_tables:255, n_buffers:256
-features: capabilities:0x87, actions:0xfff
+features: capabilities:0xc7, actions:0xfff
  LOCAL(br0): addr:aa:55:aa:55:00:00
      config:     PORT_DOWN
      state:      LINK_DOWN
@@ -60,7 +60,7 @@ do
     AT_CHECK_UNQUOTED([STRIP_XIDS stdout], [0], [dnl
 OFPT_FEATURES_REPLY: ver:0x1, dpid:fedcba9876543210
 n_tables:255, n_buffers:256
-features: capabilities:0x87, actions:0xfff
+features: capabilities:0xc7, actions:0xfff
  LOCAL(br0): addr:aa:55:aa:55:00:00
      config:     $config
      state:      $state
-- 
1.7.2.5




More information about the dev mailing list