[ovs-dev] [PATCH] ovsdb-idl: Prevent occasional hang when multiple database clients race.

Ben Pfaff blp at nicira.com
Mon Oct 31 16:15:33 UTC 2011


On Sat, Oct 29, 2011 at 04:37:36PM -0700, Justin Pettit wrote:
> On Oct 28, 2011, at 11:09 AM, Ben Pfaff wrote:
> 
> > --- a/python/ovs/db/idl.py
> > +++ b/python/ovs/db/idl.py
> > @@ -441,7 +441,7 @@ class Idl:
> >     def __txn_abort_all(self):
> >         while self._outstanding_txns:
> >             txn = self._outstanding_txns.popitem()[1]
> > -            txn._status = Transaction.TRY_AGAIN
> > +            txn._status = Transaction.AGAIN_
> 
> I think this should be AGAIN_NOW or AGAIN_WAIT.  Otherwise, looks good.

Ouch, good catch.  I'm surprised pychecker didn't report this.

I'll push this soon.



More information about the dev mailing list