[ovs-dev] [PATCH] netdev-vport: Fix support for "tap" devices.

[Jesse Gross]

On Mon, Oct 31, 2011 at 10:31 AM, Ben Pfaff <blp at nicira.com> wrote:
> Reported-by: Janis Hamme <janis.hamme at student.kit.edu>
> ---
>  lib/netdev-vport.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c
> index f6dbd03..77b151d 100644
> --- a/lib/netdev-vport.c
> +++ b/lib/netdev-vport.c
> @@ -131,7 +131,8 @@ netdev_vport_get_vport_type(const struct netdev *netdev)
>
>     return (is_vport_class(class) ? vport_class_cast(class)->type
>             : class == &netdev_internal_class ? OVS_VPORT_TYPE_INTERNAL
> -            : class == &netdev_linux_class ? OVS_VPORT_TYPE_NETDEV
> +            : (class == &netdev_linux_class ||
> +               class == &netdev_tap_class) ? OVS_VPORT_TYPE_NETDEV
>             : OVS_VPORT_TYPE_UNSPEC);

This doesn't make a lot of sense to me: I think the only real use for
tap devices is for the userspace datapath where they resemble internal
ports.  Since the userspace datapath already does this conversion
automatically, I think the right thing to do is just remove tap
devices from the documentation.