[ovs-dev] [PATCH 2/3] rhel: add ability to build kmod packages for arbitrary kernel version/variant(s)

[Ben Pfaff]

On Thu, Sep 01, 2011 at 06:01:12PM +0400, Alexey I. Froloff wrote:
> Usage:
> 
> rpmbuild --rebuild \
>   -D 'kversion KERNEL_VERSION' \
>   -D 'kflavors FLAVORS TO BUILD' \
>   openvswitch-kmod-VERSION-RELEASE.src.rpm
> 
> Signed-off-by: Alexey I. Froloff <raorn at altlinux.org>

Does this cause any change in behavior if kversion and kflavors are
not specified on the command line?  Previously, kernel_version would
not be defined in that case; with this change, it will now be defined
as the value returned by "uname -r".  I wonder (without checking)
whether this would change from building for the kernel version
associated with the RHEL version to building for whatever kernel is
currently running.

If that's the case, then doing something like:
    %{?kversion:%define kernel_version %kversion}
instead of
    %{!?kversion:%define kversion %(uname -r)}
    %define kernel_version %kversion
would seem "safer" to me.

Thanks,

Ben.