[ovs-dev] [PATCH] VLAN actions should use push/pop semantics

Ethan Jackson ethan at nicira.com
Wed Sep 7 03:04:37 UTC 2011


Relatively minor stuff, It's pretty much there.

Please use curly braces for one-line blocks in userspace.

The comment to eth_push_vlan() needs to be updated.

I think that we should keep the eth_set_vlan_tci() function around in
addition to eth_push_vlan().  The bonding code really did want
eth_set_vlan_tci() not eth_push_vlan().  With the current version of
the patch, it's going to end up double tagging packets instead of
replacing the tag.  Perhaps, eth_set_vlan_tci() could use
eth_push_vlan() in its implementation.

Thanks,
Ethan



More information about the dev mailing list