[ovs-dev] [PATCH 08/11] cfm: New cfm extended mode.

[Ben Pfaff]

Here's my real review of patch 8.

On Tue, Sep 06, 2011 at 07:32:31PM -0700, Ethan Jackson wrote:
> @@ -38,6 +38,9 @@ VLOG_DEFINE_THIS_MODULE(cfm);
>  
>  /* Ethernet destination address of CCM packets. */
>  static const uint8_t eth_addr_ccm[6] = { 0x01, 0x80, 0xC2, 0x00, 0x00, 0x30 };
> +static const uint8_t eth_addr_ccm_x[6] = {
> +    0x01, 0x23, 0x20, 0x00, 0x00, 0x30
> +};

We have the Nicira OUI scattered a few places around the tree now,
should we add some macros for it?

Is it sufficient to use a different destination MAC or should we use a
different Ethertype (in practice LLC+SNAP) also?