[ovs-dev] [PATCH] datapath: Allow a packet with no input port to omit OVS_KEY_ATTR_IN_PORT.

Ben Pfaff blp at nicira.com
Thu Sep 8 23:40:28 UTC 2011


On Thu, Sep 08, 2011 at 04:38:54PM -0700, Jesse Gross wrote:
> On Thu, Sep 8, 2011 at 4:37 PM, Ben Pfaff <blp at nicira.com> wrote:
> > On Thu, Sep 08, 2011 at 03:26:04PM -0700, Jesse Gross wrote:
> >> On Thu, Sep 8, 2011 at 11:36 AM, Ben Pfaff <blp at nicira.com> wrote:
> >> > When ovs-vswitchd executes actions on a synthesized packet, that is, on a
> >> > packet that is not being forwarded from any particular port but is being
> >> > generated by ovs-vswitchd itself or by an OpenFlow controller (using a
> >> > OFPT_PACKET_OUT message with an in_port of OFPP_NONE), there is no good
> >> > choice for the in_port to pass to the kernel in the flow in the
> >> > OVS_PACKET_CMD_EXECUTE message. ??This commit allows ovs-vswitchd to omit
> >> > the in_port entirely in this case.
> >> >
> >> > This fixes a bug in OFPT_PACKET_OUT: using an in_port of OFPP_NONE would
> >> > cause the packet to be dropped by the kernel, since that's an invalid
> >> > input port.
> >> >
> >> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> >> > Reported-by: Aaron Rosen <arosen at clemson.edu>
> >>
> >> Acked-by: Jesse Gross <jesse at nicira.com>
> >
> > Thanks. ??I pushed this to master. ??Here's the crossport to branch-1.2,
> > I assume that it looks OK? ??The only change was to s/OVS_/ODP_/ in
> > random places.
> 
> This one looks good too.

Thanks, pushed to branch-1.2.



More information about the dev mailing list