[ovs-dev] [cfm_v2 5/9] cfm: Remove cfm_remote_mpid configuration.
Ben Pfaff
blp at nicira.com
Fri Sep 9 18:06:47 UTC 2011
On Thu, Sep 08, 2011 at 06:59:49PM -0700, Ethan Jackson wrote:
> According to the 802.1ag specification, users should be able to
> configure the CFM module with a list of remote endpoints with which
> the local endpoint should have connectivity. Commit 93b8df3853
> "cfm: Remove Maintenance_Point and Monitor tables." changed the
> behavior so that only one remote endpoint could be specified. This
> commit takes it further, by disallowing specification of any
> remote endpoints.
>
> Due to this change, the semantics of the fault flag are slightly
> different. Before, a fault was triggered if any of the configured
> remote endpoints were unreachable (or with RDI), or if any
> unconfigured remote endpoints were reachable. Now a fault is
> triggered if no remote endpoints are reachable at all, or if
> reachable endpoints have set their RDI.
>
> Bug #7014.
Looks good, a few nits:
+ According to the 802.1ag specification. Each Maintenance Point should
should be:
+ According to the 802.1ag specification, each Maintenance Point should
to make a full sentence.
Also, am I reading the code correctly that too many RMPs triggers an
unexpected_recv fault? Is that what we want?
I think that there's more than one reason that a CFM can fault, but
the documentation only mentions one.
More information about the dev
mailing list