[ovs-dev] [PATCH 2/3] Debian: fail gracefully if modules can't be loaded on install

Simon Horman horms at verge.net.au
Sun Sep 11 07:49:34 UTC 2011


On Sat, Sep 10, 2011 at 03:09:31PM +0900, Simon Horman wrote:
> By registering an error-handler for the init script used
> in openvswitch-switch.postinst and detecting if module insertion fails,
> it is possible to avoid failure to install in the case where the
> openvswitch_mod module is not available.
> 
> This is done without altering the behaviour that the start target
> of the openvswtich-switch init script will fail if module insertion fails.
> 
> This patch also adds a friendly hint as as to why starting
> openvswitch-switch has failed if it is due to failure to insert
> the openvswtich_mod. This message is displayed as necessary both
> on package install and other calls to the start target of the
> init script.
> 
> ---
> 
> v2
> * Avoid using if !, as it may have portability problems
> * Avoid duplicated 'echo "/usr/share/doc..."'
> 
> v3
> * Do not ignore module insertion failure on start, instead add extra
>   logic to the postinst script. As suggested by Ben Phaff

Ben, I apologise for misspelling your name.



More information about the dev mailing list